Explicitly disable CGO in .goreleaser.yml #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In other repos, we've run into problems when the runner used to publish builds switched from macOS to Ubuntu because CGO is disabled by default on macOS but enabled on Ubuntu, and when CGO is enabled, by default the built binary will be dynamically linked. We want statically linked files on Linux so the binary works across different OSes. This commit preemptively explicitly disables CGO in `.goreleaser.yml` and `.goreleaser.prerelease.yml` to ensure the binaries remain statically linked if/when the GHA runner is changed to Ubuntu.
justinvp
added
the
impact/no-changelog-required
tgummerer
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In other repos, we've run into problems when the runner used to publish builds switched from macOS to Ubuntu because CGO is disabled by default on macOS but enabled on Ubuntu, and when CGO is enabled, by default the built binary will be dynamically linked. We want statically linked files on Linux so the binary works across different OSes.
This commit preemptively explicitly disables CGO in
.goreleaser.ymland.goreleaser.prerelease.ymlto ensure the binaries remain statically linked if/when the GHA runner is changed to Ubuntu.Reference: pulumi/pulumi-yaml#657
Fixes #112